-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document and test Button component's "small" size #566
Conversation
🦋 Changeset detectedLatest commit: 1ab06cf The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
🔍 Design token changes foundView CSS variable changes- --brand-control-small-paddingBlock: var(--base-size-12);
+ --brand-control-small-paddingBlock: var(--base-size-8); |
🟢 No visual differences foundOur visual comparison tests did not find any differences in the UI. |
👋 @joshfarrant thanks for opening this PR. Just FYI that you can update your visual snapshots locally through Docker, or directly from the PR by adding the 'update snapshots' label. Latter will commit the updated snapshots to your branch. |
This reverts commit b643b34.
Code changes LGTM 👍, nice one @joshfarrant 🙌 @auareyou would you mind giving this a quick design review / sign-off also please 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@rezrah Added a new changeset, lmk if you have any suggestions 👍 |
Co-authored-by: Rez <[email protected]>
Summary
Adds the new "small" Button size to docs, Storybook, and adds tests for Button size.
List of notable changes:
What should reviewers focus on?
it.each()
in the codebase, and equally you might not think it's necessary to test all size variations.Supporting resources (related issues, external links, etc):
Contributor checklist:
Reviewer checklist:
Screenshots: