Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release tracking #567

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Release tracking #567

merged 1 commit into from
Apr 25, 2024

Conversation

primer-css
Copy link
Contributor

@primer-css primer-css commented Apr 12, 2024

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.

Releases

@primer/[email protected]

Minor Changes

Patch Changes

  • #568 40a129d Thanks @rezrah! - Added support for optional Button and sub menu's in SubNav component.

    Also added fullWidth prop to optionally remove the default component padding.

    <SubNav>
      <SubNav.Heading href="#">Heading</SubNav.Heading>
      <SubNav.Link href="#">Link</SubNav.Link>
      <SubNav.Link href="#">Link</SubNav.Link>
      <SubNav.Link href="#">Link</SubNav.Link>
      <SubNav.Link href="#" aria-current="page">
        Link
        <SubNav.SubMenu>
          <SubNav.Link href="#">Link feature one</SubNav.Link>
          <SubNav.Link href="#">Link feature two</SubNav.Link>
          <SubNav.Link href="#">Link feature three</SubNav.Link>
          <SubNav.Link href="#">Link feature four</SubNav.Link>
        </SubNav.SubMenu>
      </SubNav.Link>
      <SubNav.Link href="#">Link</SubNav.Link>
      <SubNav.Link href="#">Link</SubNav.Link>
      <SubNav.Action href="#" variant="secondary">
        Optional CTA
      </SubNav.Action>
    </SubNav>
  • #566 eaeb50e Thanks @joshfarrant! - Adjusted block padding of small button controls from 12px to 8px.

    This change affects all small size Button and ActionMenu instances.

  • #575 89d6590 Thanks @rezrah! - Added none optiona to arrowDirection prop of Link component. This value removes the arrow entirely.

    <Link arrowDirection="none" {...rest} />
  • #573 e76c92b Thanks @joshfarrant! - Add trailingComponent prop to Hero

@primer/[email protected]

Patch Changes

  • #566 eaeb50e Thanks @joshfarrant! - Adjusted block padding of small button controls from 12px to 8px.

    This change affects all small size Button and ActionMenu instances.

@primer/[email protected]

@primer/[email protected]

@primer/[email protected]

@primer/[email protected]

Copy link
Contributor

github-actions bot commented Apr 12, 2024

🟢 No design token changes found

Copy link
Contributor

github-actions bot commented Apr 12, 2024

🟢 No visual differences found

Our visual comparison tests did not find any differences in the UI.

@rezrah
Copy link
Collaborator

rezrah commented Apr 24, 2024

Smoke test: 23/04/24

❌ Subnav changes

  • internal paddings require overriding

❌ IDE changes

  • CSP issues with file extension icons
    Screenshot 2024-04-23 at 15 47 03

  • Text sizes being overridden by dotcom
    Screenshot 2024-04-23 at 16 00 41
    ✅ Pagination
    ✅ Button updates

@rezrah
Copy link
Collaborator

rezrah commented Apr 25, 2024

Smoke test: 25/04/24

All aforementioned issues resolved through #580

✅ Subnav changes - fullWidth prop added to remove internal padding
✅ IDE component - tabIcons prop provided for CSP compliance
✅ Pagination
✅ Button updates

Result:
Screenshot 2024-04-25 at 11 07 49

Release good to go 🚀

@rezrah rezrah merged commit 8c57c9c into main Apr 25, 2024
18 checks passed
@rezrah rezrah deleted the changeset-release/main branch April 25, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants