Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pagination component #575

Merged
merged 14 commits into from
Apr 23, 2024
Merged

Add pagination component #575

merged 14 commits into from
Apr 23, 2024

Conversation

rezrah
Copy link
Collaborator

@rezrah rezrah commented Apr 18, 2024

Summary

Adds a pagination component, which is required for upcoming templates. Has feature-parity with product ui counterpart, with a few minor marketing-specific adjustments.

🔗 Documentation
🔗 Storybook

List of notable changes:

  • converted product react component, using same api and technical approach
  • applied marketing specific adjustments

What should reviewers focus on?

  • review documentation
  • review storybook examples

Supporting resources (related issues, external links, etc):

Contributor checklist:

  • All new and existing CI checks pass
  • Tests prove that the feature works and covers both happy and unhappy paths
  • Any drop in coverage, breaking changes or regressions have been documented above
  • New visual snapshots have been generated / updated for any UI changes
  • All developer debugging and non-functional logging has been removed
  • Related issues have been referenced in the PR description

Reviewer checklist:

  • Check that pull request and proposed changes adhere to our contribution guidelines and code of conduct
  • Check that tests prove the feature works and covers both happy and unhappy paths
  • Check that there aren't other open Pull Requests for the same update/change

Screenshots:

Screenshot 2024-04-18 at 14 27 06 Screenshot 2024-04-18 at 14 26 58

Copy link

changeset-bot bot commented Apr 18, 2024

🦋 Changeset detected

Latest commit: efa4af7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@primer/react-brand Minor
@primer/brand-primitives Minor
@primer/brand-e2e Minor
@primer/brand-fonts Minor
@primer/brand-config Minor
@primer/brand-storybook Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Apr 18, 2024

🟢 No design token changes found

Copy link
Contributor

github-actions bot commented Apr 18, 2024

🟢 No visual differences found

Our visual comparison tests did not find any differences in the UI.

@rezrah rezrah marked this pull request as ready for review April 18, 2024 13:34
Copy link
Contributor

@auareyou auareyou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@auareyou auareyou self-requested a review April 23, 2024 13:41
@rezrah rezrah merged commit 89d6590 into main Apr 23, 2024
14 checks passed
@rezrah rezrah deleted the rezrah/add-pagination branch April 23, 2024 14:28
@primer-css primer-css mentioned this pull request Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants